mcndave/spout
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
351 Commits 2 Branches 36 Tags
Commit Graph

107 Commits

Author SHA1 Message Date
Adrien Loison
84083985dc Various improvements 2017-10-21 19:08:46 +02:00
madflow
823fbdb43f php-cs-fixer fix 2017-10-04 13:32:54 +02:00
madflow
78f7036a7c fix row from array 2017-09-29 18:03:48 +02:00
madflow
2797052c54 make tests pass again 2017-09-29 14:47:33 +02:00
madflow
6971a793ef merge, resolve conflicts 2017-09-29 11:22:39 +02:00
Adrien Loison
b968513cb9 Fix code style 2017-09-06 00:33:43 +02:00
Adrien Loison
740fcfb8c1 Fix code before applying PHP CS Fixer 2017-09-06 00:33:43 +02:00
Adrien Loison
4ec3a21170 Random DI improvements (#458) 
* Add random DI improvements

Fixing things that were previously missed

* Split InternalFactory into Manager and Helper factories
 2017-08-27 01:44:20 +02:00
Adrien Loison
b7e46740ce Refactor readers for better di (#457) 
* Refactor readers to get a proper DI

Similar to what was done with writers, readers also needed to be updated to match the new way of doing things.
This commits promotes a better DI (factories, injection through constructors).

* Escapers should not be singletons

Instead, they should be proper object that can be injected where needed.
 2017-08-27 00:01:17 +02:00
madflow
d4e99f74c9 allow setting style to null 2017-08-01 20:15:23 +02:00
madflow
edccd21dbd some cleanup todos 2017-08-01 13:01:12 +02:00
madflow
99c327ba84 rename method 2017-07-31 21:10:48 +02:00
madflow
169dc262ab typo in method name 2017-07-31 21:09:16 +02:00
madflow
fe53d4a1a2 make all tests pass 2017-07-31 20:58:20 +02:00
madflow
23de4b4117 first shot an row RowManager and make CSV tests pass 2017-07-30 21:09:55 +02:00
madflow
968ca198cc reworked AbstractWriter, doc updates 2017-07-30 17:47:01 +02:00
madflow
cb8ba1d2a4 remove *withStyle methods from interface, docs cleanup 2017-07-30 17:26:58 +02:00
madflow
46c8e77cea first changes 2017-07-20 21:22:46 +02:00
madflow
97cdd0c627 implement cell styling and row objects 2017-07-20 21:22:46 +02:00
madflow
33c28dbf6c introduced row objects 2017-07-20 21:22:46 +02:00
Adrien Loison
3bb4fd3d48 Move Sheet to Common/Entity (#438) 
... and introduce a SheetManager
 2017-05-30 16:49:07 +02:00
Adrien Loison
30366e6a5d Inject ZipHelper through constructor (#437) 2017-05-30 15:19:05 +02:00
Adrien Loison
762dd1573a Inject GlobalFunctionsHelper through constructor for Writers (#436) 2017-05-30 14:37:38 +02:00
Adrien Loison
7ec0f565fd Rename SharedStringsHelper to SharedStringsManager (#435) 2017-05-30 14:11:18 +02:00
Adrien Loison
cc9a0b526b Refactory Writer Styles to match new code organization (#433) 
Decomposed old StyleHelper into StyleManager, StyleRegistry and StyleMerger.
 2017-05-30 13:05:18 +02:00
Adrien Loison
238756ab6e Move Style classes into Common folder (#432) 2017-05-30 00:56:50 +02:00
Adrien Loison
c4e25a168e Move entities and managers back to Common (#431) 2017-05-29 23:28:10 +02:00
Adrien Loison
878c4a9c8b Rename Factory folder to Creator (#430) 2017-05-29 23:10:24 +02:00
Adrien Loison
cebffbe80c Move Cell and Options to Entity folder (#429) 2017-05-29 22:51:12 +02:00
Adrien Loison
69b091b37c Move OptionManager from Common/Manager to Manager (#428) 2017-05-29 22:34:25 +02:00
Adrien Loison
bc17311f5f Refactor writers for better DI (#427) 
This commit is a big refactor that improves the code organization.
It focuses on how dependencies are injected into the different classes. This is now done via some factories.

Also, the code is now built around entities (data model that only exposes getters and setters), managers (used to manage an entity) and helpers (used by the managers to perform some specific tasks).

The refactoring is not fully complete, as some dependencies are still hidden...
 2017-05-29 22:18:40 +02:00
Adrien Loison
a366d0d0af Introduce an options manager for all writers (#423) 
This will improve the management of options and simplify some methods' signatures.
This commit will also help moving the code to a better state regarding Dependency Injection.
 2017-05-24 13:17:50 +02:00
madflow
4acd9ad087 Cell value objects (#383) 
* first stab at cell objects, #182
* removed comment parameter, streamlined cell detection, more tests #182
* shorter constant names, missing isFormula() #182
* first batch of changes #182
* documentation #182
 2017-05-01 12:09:24 +02:00
Adrien Loison
4a65466b61 Prevent error when close() called while writer already closed (#402) 2017-03-28 15:07:48 +02:00
Adrien Loison
33c9d2f2ed Enforce sheet name uniqueness per workbook (#397) 
Instead of across all workbooks (in case of multiple spreadsheets being created at the same time).
 2017-03-27 17:58:06 +02:00
Adrien Loison
521f799366 [XLSX] A cell should not contain more than 32,767 characters (#365) 2016-11-29 15:43:38 -08:00
Adrien Loison
984c9c1f67 Improve error message when invalid sheet name set (#364) 
Instead of listing all the requirements, only list the requirements that actually failed to be met.
 2016-11-29 14:36:57 -08:00
Adrien Loison
e276b4378e Fix crash when using associative array with empty row (#354) 2016-11-03 13:45:18 -07:00
Adrien Loison
9ce77405e0 Refactor Style::mergeWith() and StyleHelper::getStyleSectionContent() (#346) 2016-10-19 17:01:19 -07:00
Adrien Loison
b61323d7d2 Remove XLSX references in ODS Writer (#337) 2016-10-17 11:54:49 -07:00
Adrien Loison
179ab483d6 Empty rows do not need to be written for XLSX files (#336) 2016-10-17 11:40:52 -07:00
Adrien Loison
77178122c3 Fix output file deletion after exception thrown on write (#328) 
For relative paths, it would not work as the FileSystemHelper would not allow deleting a file that's not part of its base folder.
 2016-10-12 11:15:07 -07:00
Adrien Loison
23f8cc4f05 Temp files should be deleted when an exception is thrown (#327) 
If an exception is thrown while writing data, instead of letting the developer handle this situation gracefully, Spout can attempt to delete all the temporary files that were created so far, as well as the output file as it won't be completed and therefore corrupted.
 2016-10-11 15:08:37 -07:00
Hastegan
30aa1b87e2 Fix boolean notation in PHPDoc (#314) 2016-09-16 15:12:58 -07:00
Hastegan
ddb7365a79 Add a way to disable text wrapping through the api (Fix #247) (#311) 
* Add a way to disable text wrapping (Fix #247)
* Fix PHPDoc boolean notation
* Fix PHPDoc param notation
 2016-09-16 11:24:36 -07:00
Adrien Loison
3e0afd858f Apply custom style to empty cells if needed (#307) 
Fixes #295

If a row should be written with a custom style, the handling of empty cells should change.
Instead of being skipped entirely, empty cells will be applied the custom style, if this style has custom background color or borders.
If not, then the cell definition can still be skipped.
 2016-09-07 17:04:31 -07:00
Adrien Loison
d4e57b1f0d Add consistency using getCellXML() (#306) 2016-09-06 19:47:18 -07:00
Stefan
5e7a1745ac Initial extraction of method getCellXml from addRow (#302) 2016-09-02 19:48:10 -07:00
madflow
277c353984 Fix #297 (#299) 2016-08-30 10:56:52 -07:00
madflow
ff2d54cc8d Fix #276, some general refinement (#289) 
* Fix #276, some general refinement

* Failing test #267

* Fixed shared border definitions across different styles #267

* Fix finding the correct borderId
 2016-08-23 19:57:57 -07:00