From dcf7f57fe537e0547f258991d68bf3c7579a64a1 Mon Sep 17 00:00:00 2001 From: Granda Date: Wed, 11 Oct 2017 16:16:44 -0300 Subject: [PATCH] As per RFC-4180 regarding CSV, "If double-quotes are used to enclose fields, then a double-quote appearing inside a field must be escaped by preceding it with another double quote". So we are changing the calls to fgetcsv and fputcsv on GlobalFunctionsHelper in order to send the Escape Character as a parameter. To be RFC compliant, we always send the same character as the Field Enclosure character. --- src/Spout/Common/Helper/GlobalFunctionsHelper.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Spout/Common/Helper/GlobalFunctionsHelper.php b/src/Spout/Common/Helper/GlobalFunctionsHelper.php index 608854a..0483153 100644 --- a/src/Spout/Common/Helper/GlobalFunctionsHelper.php +++ b/src/Spout/Common/Helper/GlobalFunctionsHelper.php @@ -86,7 +86,7 @@ class GlobalFunctionsHelper */ public function fgetcsv($handle, $length = null, $delimiter = null, $enclosure = null) { - return fgetcsv($handle, $length, $delimiter, $enclosure); + return fgetcsv($handle, $length, $delimiter, $enclosure, $enclosure); } /** @@ -101,7 +101,7 @@ class GlobalFunctionsHelper */ public function fputcsv($handle, array $fields, $delimiter = null, $enclosure = null) { - return fputcsv($handle, $fields, $delimiter, $enclosure); + return fputcsv($handle, $fields, $delimiter, $enclosure, $enclosure); } /**