Refactory Writer Styles to match new code organization (#433)

Decomposed old StyleHelper into StyleManager, StyleRegistry and StyleMerger.

tests/Spout/Writer/ODS/Helper/StyleHelperTest.php

@@ -1,91 +0,0 @@
-<?php
-
-namespace Box\Spout\Writer\ODS\Helper;
-
-use Box\Spout\Writer\Common\Creator\Style\StyleBuilder;
-use Box\Spout\Writer\Common\Entity\Style\Style;
-use Box\Spout\Writer\Common\Manager\StyleManager;
-
-/**
- * Class StyleHelperTest
- *
- * @package Box\Spout\Writer\ODS\Helper
- */
-class StyleHelperTest extends \PHPUnit_Framework_TestCase
-{
-    /** @var Style */
-    protected $defaultStyle;
-
-    /** @var StyleHelper */
-    private $styleHelper;
-
-    /**
-     * @return void
-     */
-    public function setUp()
-    {
-        $this->defaultStyle = (new StyleBuilder())->build();
-        $this->styleHelper = new StyleHelper($this->defaultStyle, new StyleManager());
-    }
-
-    /**
-     * @return void
-     */
-    public function testRegisterStyleShouldUpdateId()
-    {
-        $style1 = (new StyleBuilder())->setFontBold()->build();
-        $style2 = (new StyleBuilder())->setFontUnderline()->build();
-
-        $this->assertEquals(0, $this->defaultStyle->getId(), 'Default style ID should be 0');
-        $this->assertNull($style1->getId());
-        $this->assertNull($style2->getId());
-
-        $registeredStyle1 = $this->styleHelper->registerStyle($style1);
-        $registeredStyle2 = $this->styleHelper->registerStyle($style2);
-
-        $this->assertEquals(1, $registeredStyle1->getId());
-        $this->assertEquals(2, $registeredStyle2->getId());
-    }
-
-    /**
-     * @return void
-     */
-    public function testRegisterStyleShouldReuseAlreadyRegisteredStyles()
-    {
-        $style = (new StyleBuilder())->setFontBold()->build();
-
-        $registeredStyle1 = $this->styleHelper->registerStyle($style);
-        $registeredStyle2 = $this->styleHelper->registerStyle($style);
-
-        $this->assertEquals(1, $registeredStyle1->getId());
-        $this->assertEquals(1, $registeredStyle2->getId());
-    }
-
-    /**
-     * @return void
-     */
-    public function testApplyExtraStylesIfNeededShouldApplyWrapTextIfCellContainsNewLine()
-    {
-        $style = clone $this->defaultStyle;
-
-        $this->assertFalse($style->shouldWrapText());
-
-        $updatedStyle = $this->styleHelper->applyExtraStylesIfNeeded($style, [12, 'single line', "multi\nlines", null]);
-
-        $this->assertTrue($updatedStyle->shouldWrapText());
-    }
-
-    /**
-     * @return void
-     */
-    public function testApplyExtraStylesIfNeededShouldDoNothingIfWrapTextAlreadyApplied()
-    {
-        $style = (new StyleBuilder())->setShouldWrapText()->build();
-
-        $this->assertTrue($style->shouldWrapText());
-
-        $updatedStyle = $this->styleHelper->applyExtraStylesIfNeeded($style, ["multi\nlines"]);
-
-        $this->assertTrue($updatedStyle->shouldWrapText());
-    }
-}

tests/Spout/Writer/ODS/Manager/Style/StyleRegistryTest.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Box\Spout\Writer\ODS\Manager\Style;
+
+use Box\Spout\Writer\Common\Creator\Style\StyleBuilder;
+
+/**
+ * Class StyleRegistryTest
+ *
+ * @package Box\Spout\Writer\ODS\Manager\Style
+ */
+class StyleRegistryTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @return StyleRegistry
+     */
+    private function getStyleRegistry()
+    {
+        $defaultStyle = (new StyleBuilder())->build();
+        return new StyleRegistry($defaultStyle);
+    }
+
+    /**
+     * @return void
+     */
+    public function testRegisterStyleKeepsTrackOfUsedFonts()
+    {
+        $styleRegistry = $this->getStyleRegistry();
+
+        $this->assertEquals(1, count($styleRegistry->getUsedFonts()), 'There should only be the default font name');
+
+        $style1 = (new StyleBuilder())->setFontName("MyFont1")->build();
+        $styleRegistry->registerStyle($style1);
+
+        $style2 = (new StyleBuilder())->setFontName("MyFont2")->build();
+        $styleRegistry->registerStyle($style2);
+
+        $this->assertEquals(3, count($styleRegistry->getUsedFonts()), 'There should be 3 fonts registered');
+    }
+}

tests/Spout/Writer/ODS/WriterWithStyleTest.php

@@ -22,8 +22,8 @@ class WriterWithStyleTest extends \PHPUnit_Framework_TestCase
 {
     use TestUsingResource;
 
-    /** @var \Box\Spout\Writer\Common\Entity\Style\Style */
-    protected $defaultStyle;
+    /** @var Style */
+    private $defaultStyle;
 
     /**
      * @return void