hopefullythelastone

src/Spout/Common/Entity/Style/NumberFormat.php

@@ -36,16 +36,6 @@ class NumberFormat
         }
     }
 
-    /**
-     * @param int $id
-     * @return NumberFormat
-     */
-    public function setId($id)
-    {
-        $this->id = $id;
-        return $this;
-    }
-
     /**
      * @param bool $commas
      * @return NumberFormat
@@ -56,14 +46,6 @@ class NumberFormat
         return $this;
     }
 
-    /**
-     * @return int|null
-     */
-    public function getId()
-    {
-        return $this->id;
-    }
-
     /**
      * @param int $type
      * @return NumberFormat

src/Spout/Writer/XLSX/Manager/Style/StyleManager.php

@@ -75,7 +75,8 @@ EOD;
         foreach ($registeredFormats as $styleId) {
             $style = $this->styleRegistry->getStyleFromStyleId($styleId);
             $format = $style->getNumberFormat();
-            $content .= '<numFmt numFmtId="'.$format->getId().'" formatCode="'.$format->getFormatCode().'"/>';
+            $formatId = $this->styleRegistry->getNumberFormatIdForStyleId($styleId);
+            $content .= '<numFmt numFmtId="'.$formatId.'" formatCode="'.$format->getFormatCode().'"/>';
         }
 
         $content .= '</numFmts>';

src/Spout/Writer/XLSX/Manager/Style/StyleRegistry.php

@@ -121,10 +121,8 @@ class StyleRegistry extends \Box\Spout\Writer\Common\Manager\Style\StyleRegistry
                 $registeredFormatId = $this->styleIdToNumberFormatMappingTable[$registeredStyleId];
                 $this->styleIdToNumberFormatMappingTable[$styleId] = $registeredFormatId;
             } else {
-                $formatId = count($this->registeredNumberFormats);
                 $this->registeredNumberFormats[$serializedFormat] = $styleId;
-                $this->styleIdToNumberFormatMappingTable[$styleId] = $formatId;
+                $this->styleIdToNumberFormatMappingTable[$styleId] = count($this->registeredNumberFormats);
-                $format->setId($formatId);
             }
         } else {
             // The fillId maps a style to a fill declaration