Merge pull request #21 from box/fix_empty_shared_string_bug

Fix empty shared string bug
This commit is contained in:
Adrien Loison committed 2015-04-16 13:08:56 -07:00
commit a538813827
3 files changed
+14 -1

No files matched your search

@@ -257,7 +257,7 @@ class SharedStringsHelper
$sharedString = $this->unescapeLineFeed($escapedSharedString); $sharedString = $this->unescapeLineFeed($escapedSharedString);
} }
if (!$sharedString) { if ($sharedString === null) {
throw new SharedStringNotFoundException("Shared string not found for index: $sharedStringIndex"); throw new SharedStringNotFoundException("Shared string not found for index: $sharedStringIndex");
} }
+13
View File
@@ -140,6 +140,19 @@ class XLSXTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expectedRows, $allRows); $this->assertEquals($expectedRows, $allRows);
} }
/**
* @return void
*/
public function testReadShouldSupportEmptySharedString()
{
$allRows = $this->getAllRowsForFile('sheet_with_empty_shared_string.xlsx');
$expectedRows = [
['s1--A1', '', 's1--C1'],
];
$this->assertEquals($expectedRows, $allRows);
}
/** /**
* @return void * @return void
*/ */