mcndave/spout
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove StyleMerger from RowManager

Browse Source
This commit is contained in:
Adrien Loison 2017-11-18 20:50:16 +01:00
parent a665b974fa
commit 97f89b1726
2 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Spout/Writer/Common/Manager/RowManager.php
View File

@ -3,23 +3,9 @@
namespace Box\Spout\Writer\Common\Manager; namespace Box\Spout\Writer\Common\Manager;
use Box\Spout\Writer\Common\Entity\Row; use Box\Spout\Writer\Common\Entity\Row;
use Box\Spout\Writer\Common\Manager\Style\StyleMerger;
class RowManager class RowManager
{ {
/**
* @var StyleMerger
*/
protected $styleMerger;
/**
* @param StyleMerger $styleMerger
*/
public function __construct(StyleMerger $styleMerger)
{
$this->styleMerger = $styleMerger;
}
/** /**
* Detect whether a row is considered empty. * Detect whether a row is considered empty.
* An empty row has either no cells at all - or only one empty cell * An empty row has either no cells at all - or only one empty cell

3
tests/Spout/Writer/Common/Manager/RowManagerTest.php
View File

@ -5,7 +5,6 @@ namespace Spout\Writer\Common\Manager;
use Box\Spout\Writer\Common\Entity\Cell; use Box\Spout\Writer\Common\Entity\Cell;
use Box\Spout\Writer\Common\Entity\Row; use Box\Spout\Writer\Common\Entity\Row;
use Box\Spout\Writer\Common\Manager\RowManager; use Box\Spout\Writer\Common\Manager\RowManager;
use Box\Spout\Writer\Common\Manager\Style\StyleMerger;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
class RowManagerTest extends TestCase class RowManagerTest extends TestCase
@ -32,7 +31,7 @@ class RowManagerTest extends TestCase
*/ */
public function testIsEmptyRow(array $cells, $expectedIsEmpty) public function testIsEmptyRow(array $cells, $expectedIsEmpty)
{ {
$rowManager = new RowManager(new StyleMerger()); $rowManager = new RowManager();
$row = new Row($cells, null, $rowManager); $row = new Row($cells, null, $rowManager);
$this->assertEquals($expectedIsEmpty, $rowManager->isEmpty($row)); $this->assertEquals($expectedIsEmpty, $rowManager->isEmpty($row));