Adding more tests

src/Spout/Common/Helper/FileSystemHelper.php

@@ -63,7 +63,7 @@ class FileSystemHelper
         $filePath = $parentFolderPath . '/' . $fileName;
 
         $wasCreationSuccessful = file_put_contents($filePath, $fileContents);
-        if (!$wasCreationSuccessful) {
+        if ($wasCreationSuccessful === false) {
             throw new IOException('Unable to create file: ' . $filePath);
         }
 

src/Spout/Reader/XLSX/Helper/SharedStringsHelper.php

@@ -154,7 +154,8 @@ class SharedStringsHelper
 
         $readError = libxml_get_last_error();
         if ($readError !== false) {
-            throw new IOException("The sharedStrings.xml file is invalid and cannot be read. [{$readError->message}]");
+            $readErrorMessage = trim($readError->message);
+            throw new IOException("The sharedStrings.xml file is invalid and cannot be read. [{$readErrorMessage}]");
         }
 
         // reset the setting to display XML warnings/errors

src/Spout/Reader/XLSX/RowIterator.php

@@ -131,12 +131,19 @@ class RowIterator implements IteratorInterface
      *
      * @return void
      * @throws \Box\Spout\Reader\Exception\SharedStringNotFoundException If a shared string was not found
+     * @throws \Box\Spout\Common\Exception\IOException If unable to read the sheet data XML
      */
     public function next()
     {
         $isInsideRowTag = false;
         $rowData = [];
 
+        // Use internal errors to avoid displaying lots of warning messages in case of invalid file
+        // For instance on HHVM, XMLReader->open() won't fail when trying to read a unexisting file within a zip...
+        // But the XMLReader->read() will fail!
+        libxml_clear_errors();
+        libxml_use_internal_errors(true);
+
         while ($this->xmlReader->read()) {
             if ($this->xmlReader->nodeType == \XMLReader::ELEMENT && $this->xmlReader->name === self::XML_NODE_DIMENSION) {
                 // Read dimensions of the sheet
@@ -180,6 +187,12 @@ class RowIterator implements IteratorInterface
             }
         }
 
+        $readError = libxml_get_last_error();
+        if ($readError !== false) {
+            $readErrorMessage = trim($readError->message);
+            throw new IOException("The {$this->sheetDataXMLFilePath} file cannot be read. [{$readErrorMessage}]");
+        }
+
         $this->rowDataBuffer = $rowData;
     }