mcndave/spout
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract common functionality to trait for easier reuse, fix default row height for XLSX

Browse Source
This commit is contained in:
Alexander Hofstede committed 2019-12-17 20:31:26 +01:00
1 parent 09a624ef8e
commit 6db9871722
4 files changed
+97 -60
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/Spout/Writer/XLSX/SheetTest.php
+3 -2
View File
@@ -117,7 +117,7 @@ class SheetTest extends TestCase
$writer = WriterEntityFactory::createXLSXWriter();
$writer->openToFile($resourcePath);
$writer->setDefaultColumnWidth(10.0);
$writer->setDefaultRowHeight(10.0);
$writer->setDefaultRowHeight(20.0);
$writer->addRow($this->createRowFromValues(['xlsx--11', 'xlsx--12']));
$writer->close();
@@ -126,7 +126,8 @@ class SheetTest extends TestCase
$this->assertContains('<sheetFormatPr', $xmlContents, 'No sheetFormatPr tag found in sheet');
$this->assertContains(' defaultColWidth="10', $xmlContents, 'No default column width found in sheet');
$this->assertContains(' defaultRowHeight="10', $xmlContents, 'No default row height found in sheet');
$this->assertContains(' defaultRowHeight="20', $xmlContents, 'No default row height found in sheet');
$this->assertContains(' customHeight="1"', $xmlContents, 'No row height override flag found in row');
}
public function testWritesDefaultRequiredRowHeightIfOmitted()