From 6d7719c86dbf52c2e48b57fb362a353a9d1789a4 Mon Sep 17 00:00:00 2001 From: madflow Date: Sat, 29 Apr 2017 09:35:55 +0200 Subject: [PATCH] documentation #182 --- src/Spout/Writer/Common/Cell.php | 4 ++-- src/Spout/Writer/ODS/Internal/Worksheet.php | 1 + src/Spout/Writer/XLSX/Internal/Worksheet.php | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Spout/Writer/Common/Cell.php b/src/Spout/Writer/Common/Cell.php index 4781fbe..bbb0d91 100644 --- a/src/Spout/Writer/Common/Cell.php +++ b/src/Spout/Writer/Common/Cell.php @@ -50,7 +50,7 @@ class Cell /** * The cell type - * @var int + * @var int|null */ protected $type = null; @@ -81,7 +81,7 @@ class Cell } /** - * @return mixed|null + * @return int|null */ public function getType() { diff --git a/src/Spout/Writer/ODS/Internal/Worksheet.php b/src/Spout/Writer/ODS/Internal/Worksheet.php index 39dbcf6..9c44798 100644 --- a/src/Spout/Writer/ODS/Internal/Worksheet.php +++ b/src/Spout/Writer/ODS/Internal/Worksheet.php @@ -192,6 +192,7 @@ class Worksheet implements WorksheetInterface $data .= ' table:number-columns-repeated="' . $numTimesValueRepeated . '"'; } + /** @TODO Remove code duplication with XLSX writer: https://github.com/box/spout/pull/383#discussion_r113292746 */ if ($cellValue instanceof Cell) { $cell = $cellValue; } else { diff --git a/src/Spout/Writer/XLSX/Internal/Worksheet.php b/src/Spout/Writer/XLSX/Internal/Worksheet.php index cef4309..7f71829 100644 --- a/src/Spout/Writer/XLSX/Internal/Worksheet.php +++ b/src/Spout/Writer/XLSX/Internal/Worksheet.php @@ -214,6 +214,7 @@ EOD; $cellXML = '