ODS writer

Added ODS writer
Refactored XLSX writer to abstract some pieces into an abstract multi-sheets writer
Created an abstract style helper
Moved shared components around

tests/Spout/Writer/XLSX/SheetTest.php

@@ -4,6 +4,7 @@ namespace Box\Spout\Writer\XLSX;
 
 use Box\Spout\Common\Type;
 use Box\Spout\TestUsingResource;
+use Box\Spout\Writer\Common\Sheet;
 use Box\Spout\Writer\WriterFactory;
 
 /**
@@ -51,64 +52,6 @@ class SheetTest extends \PHPUnit_Framework_TestCase
         $this->assertSheetNameEquals($customSheetName, $fileName, "The sheet name should have been changed to '$customSheetName'");
     }
 
-    /**
-     * @return array
-     */
-    public function dataProviderForInvalidSheetNames()
-    {
-        return [
-            [null],
-            [21],
-            [''],
-            ['this title exceeds the 31 characters limit'],
-            ['Illegal \\'],
-            ['Illegal /'],
-            ['Illegal ?'],
-            ['Illegal *'],
-            ['Illegal :'],
-            ['Illegal ['],
-            ['Illegal ]'],
-            ['\'Illegal start'],
-            ['Illegal end\''],
-        ];
-    }
-
-    /**
-     * @dataProvider dataProviderForInvalidSheetNames
-     * @expectedException \Box\Spout\Writer\Exception\InvalidSheetNameException
-     *
-     * @param string $customSheetName
-     * @return void
-     */
-    public function testSetSheetNameShouldThrowOnInvalidName($customSheetName)
-    {
-        $fileName = 'test_set_name_with_invalid_name_should_throw_exception.xlsx';
-        $this->writeDataAndReturnSheetWithCustomName($fileName, $customSheetName);
-    }
-
-    /**
-     * @return void
-     */
-    public function testSetSheetNameShouldNotThrowWhenSettingSameNameAsCurrentOne()
-    {
-        $fileName = 'test_set_name_with_same_as_current.xlsx';
-        $this->createGeneratedFolderIfNeeded($fileName);
-        $resourcePath = $this->getGeneratedResourcePath($fileName);
-
-        $writer = WriterFactory::create(Type::XLSX);
-        $writer->openToFile($resourcePath);
-
-        $customSheetName = 'Sheet name';
-        $sheet = $writer->getCurrentSheet();
-        $sheet->setName($customSheetName);
-        $sheet->setName($customSheetName);
-
-        $writer->addRow(['xlsx--11', 'xlsx--12']);
-        $writer->close();
-
-        $this->assertSheetNameEquals($customSheetName, $fileName, "The sheet name should have been changed to '$customSheetName'");
-    }
-
     /**
      * @expectedException \Box\Spout\Writer\Exception\InvalidSheetNameException
      * @return void
@@ -186,6 +129,6 @@ class SheetTest extends \PHPUnit_Framework_TestCase
         $pathToWorkbookFile = $resourcePath . '#xl/workbook.xml';
         $xmlContents = file_get_contents('zip://' . $pathToWorkbookFile);
 
-        $this->assertContains('<sheet name="' . $expectedName . '"', $xmlContents, $message);
+        $this->assertContains("<sheet name=\"$expectedName\"", $xmlContents, $message);
     }
 }