mcndave/spout
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactoring tests

Browse Source
This commit is contained in:
Gabriel Caruso authored and Adrien Loison committed 2017-12-15 10:09:18 +01:00
1 parent 9f4e28b3fd
commit 4c7adbb33f
16 files changed
+52 -52
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/Spout/Common/Entity/RowTest.php
+1 -1
View File
@@ -96,6 +96,6 @@ class RowTest extends \PHPUnit\Framework\TestCase
->setStyle($this->getStyleMock())
->setCells([]);
$this->assertTrue(is_object($row));
$this->assertInternalType('object', $row);
}
}
tests/Spout/Common/Entity/Style/BorderTest.php
+4 -4
View File
@@ -67,7 +67,7 @@ class BorderTest extends TestCase
->addPart(new BorderPart(Border::BOTTOM))
->addPart(new BorderPart(Border::LEFT));
$this->assertEquals(4, count($border->getParts()), 'There should never be more than 4 border parts');
$this->assertCount(4, $border->getParts(), 'There should never be more than 4 border parts');
}
/**
@@ -80,7 +80,7 @@ class BorderTest extends TestCase
new BorderPart(Border::LEFT),
]);
$this->assertEquals(1, count($border->getParts()), 'It should be possible to set the border parts');
$this->assertCount(1, $border->getParts(), 'It should be possible to set the border parts');
}
/**
@@ -94,7 +94,7 @@ class BorderTest extends TestCase
->setBorderLeft()
->setBorderRight()
->build();
$this->assertEquals(4, count($border->getParts()), 'The border builder exposes a fluent interface');
$this->assertCount(4, $border->getParts(), 'The border builder exposes a fluent interface');
}
/**
@@ -110,7 +110,7 @@ class BorderTest extends TestCase
$borderPart = new BorderPart($allowedName, $color, $allowedWidth, $allowedStyle);
$border = new Border();
$border->addPart($borderPart);
$this->assertEquals(1, count($border->getParts()));
$this->assertCount(1, $border->getParts());
/** @var $part BorderPart */
$part = $border->getParts()[$allowedName];
tests/Spout/Common/Manager/OptionsManagerTest.php
+1 -1
View File
@@ -16,7 +16,7 @@ class OptionsManagerTest extends TestCase
{
$optionsManager = new FakeOptionsManager();
$this->assertEquals('foo-val', $optionsManager->getOption('foo'));
$this->assertEquals(false, $optionsManager->getOption('bar'));
$this->assertFalse($optionsManager->getOption('bar'));
}
/**