mcndave/spout
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove HHVM workarounds

Browse Source
This commit is contained in:
madflow 2018-06-12 07:53:22 +02:00
parent 195b0d4bda
commit 31b8e50c25
3 changed files with 7 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/Spout/Common/Helper/Escaper/ODS.php
View File

@ -9,40 +9,22 @@ namespace Box\Spout\Common\Helper\Escaper;
class ODS implements EscaperInterface class ODS implements EscaperInterface
{ {
/** /**
* Escapes the given string to make it compatible with XLSX * Escapes the given string to make it compatible with ODS
* *
* @param string $string The string to escape * @param string $string The string to escape
* @return string The escaped string * @return string The escaped string
*/ */
public function escape($string) public function escape($string)
{ {
if (defined('ENT_DISALLOWED')) { // 'ENT_DISALLOWED' ensures that invalid characters in the given document type are replaced.
// 'ENT_DISALLOWED' ensures that invalid characters in the given document type are replaced. // Otherwise control characters like a vertical tab "\v" will make the XML document unreadable
// Otherwise control characters like a vertical tab "\v" will make the XML document unreadable by the XML processor // by the XML processor
// @link https://github.com/box/spout/issues/329 // @link https://github.com/box/spout/issues/329
$replacedString = htmlspecialchars($string, ENT_NOQUOTES | ENT_DISALLOWED); return htmlspecialchars($string, ENT_NOQUOTES | ENT_DISALLOWED);
} else {
// We are on hhvm or any other engine that does not support ENT_DISALLOWED.
//
// @NOTE: Using ENT_NOQUOTES as only XML entities ('<', '>', '&') need to be encoded.
// Single and double quotes can be left as is.
$escapedString = htmlspecialchars($string, ENT_NOQUOTES);
// control characters values are from 0 to 1F (hex values) in the ASCII table
// some characters should not be escaped though: "\t", "\r" and "\n".
$regexPattern = '[\x00-\x08' .
// skipping "\t" (0x9) and "\n" (0xA)
'\x0B-\x0C' .
// skipping "\r" (0xD)
'\x0E-\x1F]';
$replacedString = preg_replace("/$regexPattern/", '<27>', $escapedString);
}
return $replacedString;
} }
/** /**
* Unescapes the given string to make it compatible with XLSX * Unescapes the given string to make it compatible with ODS
* *
* @param string $string The string to unescape * @param string $string The string to unescape
* @return string The unescaped string * @return string The unescaped string

1
src/Spout/Reader/Wrapper/XMLReader.php
View File

@ -27,7 +27,6 @@ class XMLReader extends \XMLReader
// We need to check first that the file we are trying to read really exist because: // We need to check first that the file we are trying to read really exist because:
// - PHP emits a warning when trying to open a file that does not exist. // - PHP emits a warning when trying to open a file that does not exist.
// - HHVM does not check if file exists within zip file (@link https://github.com/facebook/hhvm/issues/5779)
if ($this->fileExistsWithinZip($realPathURI)) { if ($this->fileExistsWithinZip($realPathURI)) {
$wasOpenSuccessful = $this->open($realPathURI, null, LIBXML_NONET); $wasOpenSuccessful = $this->open($realPathURI, null, LIBXML_NONET);
} }

36
tests/Spout/Reader/Wrapper/XMLReaderTest.php
View File

@ -28,42 +28,6 @@ class XMLReaderTest extends TestCase
$this->assertFalse($wasOpenSuccessful); $this->assertFalse($wasOpenSuccessful);
} }
/**
* Testing a HHVM bug: https://github.com/facebook/hhvm/issues/5779
* The associated code in XMLReader::open() can be removed when the issue is fixed (and this test starts failing).
* @see XMLReader::open()
*
* @return void
*/
public function testHHVMStillDoesNotComplainWhenCallingOpenWithFileInsideZipNotExisting()
{
// Test should only be run on HHVM
if ($this->isRunningHHVM()) {
$resourcePath = $this->getResourcePath('one_sheet_with_inline_strings.xlsx');
$nonExistingXMLFilePath = 'zip://' . $resourcePath . '#path/to/fake/file.xml';
libxml_clear_errors();
$initialUseInternalErrorsSetting = libxml_use_internal_errors(true);
// using the built-in XMLReader
$xmlReader = new \XMLReader();
$this->assertNotFalse($xmlReader->open($nonExistingXMLFilePath));
$this->assertFalse(libxml_get_last_error());
libxml_use_internal_errors($initialUseInternalErrorsSetting);
} else {
$this->markTestSkipped();
}
}
/**
* @return bool TRUE if running on HHVM, FALSE otherwise
*/
private function isRunningHHVM()
{
return defined('HHVM_VERSION');
}
/** /**
* @return void * @return void
*/ */