mcndave/spout
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

corrected test name to describe correctly the function

Browse Source
This commit is contained in:
alexisparron 2017-07-20 17:23:22 +02:00
parent e31b31b3ac
commit 243c0e12c2
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/Spout/Writer/XLSX/SheetTest.php
View File

@ -47,7 +47,7 @@ class SheetTest extends \PHPUnit_Framework_TestCase
{ {
$fileName = 'test_set_name_should_create_sheet_with_custom_name.xlsx'; $fileName = 'test_set_name_should_create_sheet_with_custom_name.xlsx';
$customSheetName = 'CustomName'; $customSheetName = 'CustomName';
$this->writeDataAndReturnSheetWithCustomName($fileName, $customSheetName); $this->writeDataToSheetWithCustomName($fileName, $customSheetName);
$this->assertSheetNameEquals($customSheetName, $fileName, "The sheet name should have been changed to '$customSheetName'"); $this->assertSheetNameEquals($customSheetName, $fileName, "The sheet name should have been changed to '$customSheetName'");
} }
@ -82,10 +82,9 @@ class SheetTest extends \PHPUnit_Framework_TestCase
public function testSetSheetVisibilityShouldCreateSheetHidden() public function testSetSheetVisibilityShouldCreateSheetHidden()
{ {
$fileName = 'test_set_visibility_should_create_sheet_hidden.xlsx'; $fileName = 'test_set_visibility_should_create_sheet_hidden.xlsx';
// $customSheetName = 'CustomName'; $this->writeDataToHiddenSheet($fileName);
$this->writeDataAndReturnSheetHidden($fileName);
$this->assertSheetVisibilityEquals(false, $fileName, "The sheet visibility should have been changed to 'false'"); $this->assertIsHiddenSheet( $fileName, "The sheet visibility should have been changed to 'hidden'");
} }
/** /**
@ -93,7 +92,7 @@ class SheetTest extends \PHPUnit_Framework_TestCase
* @param string $sheetName * @param string $sheetName
* @return Sheet * @return Sheet
*/ */
private function writeDataAndReturnSheetWithCustomName($fileName, $sheetName) private function writeDataToSheetWithCustomName($fileName, $sheetName)
{ {
$this->createGeneratedFolderIfNeeded($fileName); $this->createGeneratedFolderIfNeeded($fileName);
$resourcePath = $this->getGeneratedResourcePath($fileName); $resourcePath = $this->getGeneratedResourcePath($fileName);
@ -132,9 +131,9 @@ class SheetTest extends \PHPUnit_Framework_TestCase
/** /**
* @param string $fileName * @param string $fileName
* @return Sheet * @return void
*/ */
private function writeDataAndReturnSheetHidden($fileName) private function writeDataToHiddenSheet($fileName)
{ {
$this->createGeneratedFolderIfNeeded($fileName); $this->createGeneratedFolderIfNeeded($fileName);
$resourcePath = $this->getGeneratedResourcePath($fileName); $resourcePath = $this->getGeneratedResourcePath($fileName);
@ -170,7 +169,7 @@ class SheetTest extends \PHPUnit_Framework_TestCase
* @param string $message * @param string $message
* @return void * @return void
*/ */
private function assertSheetVisibilityEquals($expectedVisibility, $fileName, $message = '') private function assertIsHiddenSheet( $fileName, $message = '')
{ {
$resourcePath = $this->getGeneratedResourcePath($fileName); $resourcePath = $this->getGeneratedResourcePath($fileName);
$pathToWorkbookFile = $resourcePath . '#xl/workbook.xml'; $pathToWorkbookFile = $resourcePath . '#xl/workbook.xml';