mcndave/spout
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix risky tests and assert true for silent tests

Browse Source
This commit is contained in:
madflow 2018-03-23 18:29:58 +01:00 committed by Adrien Loison
parent 29cf6245a1
commit 01ad5af2c5
6 changed files with 36 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/Spout/Common/Entity/Style/BorderTest.php
View File

@ -22,6 +22,7 @@ class BorderTest extends TestCase
$withConstructorParams = new Border([ $withConstructorParams = new Border([
new BorderPart(Border::LEFT), new BorderPart(Border::LEFT),
]); ]);
$this->assertTrue(true);
} }
/** /**

2
tests/Spout/Reader/Wrapper/XMLReaderTest.php
View File

@ -51,6 +51,8 @@ class XMLReaderTest extends TestCase
$this->assertFalse(libxml_get_last_error()); $this->assertFalse(libxml_get_last_error());
libxml_use_internal_errors($initialUseInternalErrorsSetting); libxml_use_internal_errors($initialUseInternalErrorsSetting);
} else {
$this->markTestSkipped();
} }
} }

1
tests/Spout/Writer/CSV/WriterTest.php
View File

@ -89,6 +89,7 @@ class WriterTest extends TestCase
$writer->openToFile($resourcePath); $writer->openToFile($resourcePath);
$writer->close(); $writer->close();
$writer->close(); // This call should not cause any error $writer->close(); // This call should not cause any error
$this->assertTrue(true);
} }
/** /**

2
tests/Spout/Writer/Common/Entity/SheetTest.php
View File

@ -101,6 +101,7 @@ class SheetTest extends TestCase
$sheet = $this->createSheet(0, 'workbookId1'); $sheet = $this->createSheet(0, 'workbookId1');
$sheet->setName($customSheetName); $sheet->setName($customSheetName);
$sheet->setName($customSheetName); $sheet->setName($customSheetName);
$this->assertTrue(true);
} }
/** /**
@ -134,5 +135,6 @@ class SheetTest extends TestCase
$sheet = $this->createSheet(1, 'workbookId3'); $sheet = $this->createSheet(1, 'workbookId3');
$sheet->setName($customSheetName); $sheet->setName($customSheetName);
$this->assertTrue(true);
} }
} }

25
tests/Spout/Writer/ODS/WriterTest.php
View File

@ -202,6 +202,7 @@ class WriterTest extends TestCase
$writer->openToFile($resourcePath); $writer->openToFile($resourcePath);
$writer->close(); $writer->close();
$writer->close(); // This call should not cause any error $writer->close(); // This call should not cause any error
$this->assertTrue(true);
} }
/** /**
@ -218,8 +219,8 @@ class WriterTest extends TestCase
$this->writeToODSFile($dataRows, $fileName); $this->writeToODSFile($dataRows, $fileName);
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWritten($fileName, $cellValue); $this->assertValueWasWritten($fileName, $cell->getValue());
} }
} }
} }
@ -240,8 +241,8 @@ class WriterTest extends TestCase
for ($i = 1; $i <= $numSheets; $i++) { for ($i = 1; $i <= $numSheets; $i++) {
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWritten($fileName, $cellValue); $this->assertValueWasWritten($fileName, $cell->getValue());
} }
} }
} }
@ -260,8 +261,8 @@ class WriterTest extends TestCase
$this->writeToODSFile($dataRows, $fileName); $this->writeToODSFile($dataRows, $fileName);
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWritten($fileName, $cellValue); $this->assertValueWasWritten($fileName, $cell->getValue());
} }
} }
} }
@ -366,18 +367,18 @@ class WriterTest extends TestCase
$writer->close(); $writer->close();
foreach ($dataRowsSheet1 as $dataRow) { foreach ($dataRowsSheet1 as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1'); $this->assertValueWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
} }
} }
foreach ($dataRowsSheet2 as $dataRow) { foreach ($dataRowsSheet2 as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWrittenToSheet($fileName, 2, $cellValue, 'Data should have been written in Sheet 2'); $this->assertValueWasWrittenToSheet($fileName, 2, $cell->getValue(), 'Data should have been written in Sheet 2');
} }
} }
foreach ($dataRowsSheet1Again as $dataRow) { foreach ($dataRowsSheet1Again as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1'); $this->assertValueWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
} }
} }
} }

33
tests/Spout/Writer/XLSX/WriterTest.php
View File

@ -233,6 +233,7 @@ class WriterTest extends TestCase
$writer->openToFile($resourcePath); $writer->openToFile($resourcePath);
$writer->close(); $writer->close();
$writer->close(); // This call should not cause any error $writer->close(); // This call should not cause any error
$this->assertTrue(true);
} }
/** /**
@ -249,8 +250,8 @@ class WriterTest extends TestCase
$this->writeToXLSXFile($dataRows, $fileName, $shouldUseInlineStrings = true); $this->writeToXLSXFile($dataRows, $fileName, $shouldUseInlineStrings = true);
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue); $this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue());
} }
} }
} }
@ -271,8 +272,8 @@ class WriterTest extends TestCase
for ($i = 1; $i <= $numSheets; $i++) { for ($i = 1; $i <= $numSheets; $i++) {
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, $numSheets, $cellValue); $this->assertInlineDataWasWrittenToSheet($fileName, $numSheets, $cell->getValue());
} }
} }
} }
@ -292,8 +293,8 @@ class WriterTest extends TestCase
$this->writeToXLSXFile($dataRows, $fileName, $shouldUseInlineStrings = false); $this->writeToXLSXFile($dataRows, $fileName, $shouldUseInlineStrings = false);
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertSharedStringWasWritten($fileName, $cellValue); $this->assertSharedStringWasWritten($fileName, $cell->getValue());
} }
} }
} }
@ -314,8 +315,8 @@ class WriterTest extends TestCase
for ($i = 1; $i <= $numSheets; $i++) { for ($i = 1; $i <= $numSheets; $i++) {
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertSharedStringWasWritten($fileName, $cellValue); $this->assertSharedStringWasWritten($fileName, $cell->getValue());
} }
} }
} }
@ -334,8 +335,8 @@ class WriterTest extends TestCase
$this->writeToXLSXFile($dataRows, $fileName); $this->writeToXLSXFile($dataRows, $fileName);
foreach ($dataRows as $dataRow) { foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue); $this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue());
} }
} }
} }
@ -422,18 +423,18 @@ class WriterTest extends TestCase
$writer->close(); $writer->close();
foreach ($dataRowsSheet1 as $dataRow) { foreach ($dataRowsSheet1 as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1'); $this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
} }
} }
foreach ($dataRowsSheet2 as $dataRow) { foreach ($dataRowsSheet2 as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 2, $cellValue, 'Data should have been written in Sheet 2'); $this->assertInlineDataWasWrittenToSheet($fileName, 2, $cell->getValue(), 'Data should have been written in Sheet 2');
} }
} }
foreach ($dataRowsSheet1Again as $dataRow) { foreach ($dataRowsSheet1Again as $dataRow) {
foreach ($dataRow as $cellValue) { foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1'); $this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
} }
} }
} }