mcndave/spout
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix risky tests and assert true for silent tests

Browse Source
This commit is contained in:
madflow authored and Adrien Loison committed 2018-03-25 15:35:19 +02:00
1 parent 29cf6245a1
commit 01ad5af2c5
6 files changed
+36 -28
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/Spout/Writer/CSV/WriterTest.php
+1
View File
@@ -89,6 +89,7 @@ class WriterTest extends TestCase
$writer->openToFile($resourcePath);
$writer->close();
$writer->close(); // This call should not cause any error
$this->assertTrue(true);
}
/**
tests/Spout/Writer/Common/Entity/SheetTest.php
+2
View File
@@ -101,6 +101,7 @@ class SheetTest extends TestCase
$sheet = $this->createSheet(0, 'workbookId1');
$sheet->setName($customSheetName);
$sheet->setName($customSheetName);
$this->assertTrue(true);
}
/**
@@ -134,5 +135,6 @@ class SheetTest extends TestCase
$sheet = $this->createSheet(1, 'workbookId3');
$sheet->setName($customSheetName);
$this->assertTrue(true);
}
}
tests/Spout/Writer/ODS/WriterTest.php
+13 -12
View File
@@ -202,6 +202,7 @@ class WriterTest extends TestCase
$writer->openToFile($resourcePath);
$writer->close();
$writer->close(); // This call should not cause any error
$this->assertTrue(true);
}
/**
@@ -218,8 +219,8 @@ class WriterTest extends TestCase
$this->writeToODSFile($dataRows, $fileName);
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertValueWasWritten($fileName, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWritten($fileName, $cell->getValue());
}
}
}
@@ -240,8 +241,8 @@ class WriterTest extends TestCase
for ($i = 1; $i <= $numSheets; $i++) {
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertValueWasWritten($fileName, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWritten($fileName, $cell->getValue());
}
}
}
@@ -260,8 +261,8 @@ class WriterTest extends TestCase
$this->writeToODSFile($dataRows, $fileName);
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertValueWasWritten($fileName, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWritten($fileName, $cell->getValue());
}
}
}
@@ -366,18 +367,18 @@ class WriterTest extends TestCase
$writer->close();
foreach ($dataRowsSheet1 as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertValueWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1');
foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
}
}
foreach ($dataRowsSheet2 as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertValueWasWrittenToSheet($fileName, 2, $cellValue, 'Data should have been written in Sheet 2');
foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWrittenToSheet($fileName, 2, $cell->getValue(), 'Data should have been written in Sheet 2');
}
}
foreach ($dataRowsSheet1Again as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertValueWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1');
foreach ($dataRow->getCells() as $cell) {
$this->assertValueWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
}
}
}
tests/Spout/Writer/XLSX/WriterTest.php
+17 -16
View File
@@ -233,6 +233,7 @@ class WriterTest extends TestCase
$writer->openToFile($resourcePath);
$writer->close();
$writer->close(); // This call should not cause any error
$this->assertTrue(true);
}
/**
@@ -249,8 +250,8 @@ class WriterTest extends TestCase
$this->writeToXLSXFile($dataRows, $fileName, $shouldUseInlineStrings = true);
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue());
}
}
}
@@ -271,8 +272,8 @@ class WriterTest extends TestCase
for ($i = 1; $i <= $numSheets; $i++) {
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertInlineDataWasWrittenToSheet($fileName, $numSheets, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, $numSheets, $cell->getValue());
}
}
}
@@ -292,8 +293,8 @@ class WriterTest extends TestCase
$this->writeToXLSXFile($dataRows, $fileName, $shouldUseInlineStrings = false);
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertSharedStringWasWritten($fileName, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertSharedStringWasWritten($fileName, $cell->getValue());
}
}
}
@@ -314,8 +315,8 @@ class WriterTest extends TestCase
for ($i = 1; $i <= $numSheets; $i++) {
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertSharedStringWasWritten($fileName, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertSharedStringWasWritten($fileName, $cell->getValue());
}
}
}
@@ -334,8 +335,8 @@ class WriterTest extends TestCase
$this->writeToXLSXFile($dataRows, $fileName);
foreach ($dataRows as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue);
foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue());
}
}
}
@@ -422,18 +423,18 @@ class WriterTest extends TestCase
$writer->close();
foreach ($dataRowsSheet1 as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1');
foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
}
}
foreach ($dataRowsSheet2 as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertInlineDataWasWrittenToSheet($fileName, 2, $cellValue, 'Data should have been written in Sheet 2');
foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 2, $cell->getValue(), 'Data should have been written in Sheet 2');
}
}
foreach ($dataRowsSheet1Again as $dataRow) {
foreach ($dataRow as $cellValue) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cellValue, 'Data should have been written in Sheet 1');
foreach ($dataRow->getCells() as $cell) {
$this->assertInlineDataWasWrittenToSheet($fileName, 1, $cell->getValue(), 'Data should have been written in Sheet 1');
}
}
}