- Removed CSRF form validation from FormHandler / added to FormContext formExecute method.

- CRSF tokens are now consumed if a form return execute value is (bool) true, preventing double form send
This commit is contained in:
mcndave committed 2026-10-27 18:25:42 +00:00
1 parent 6d0a68c6db
commit f1ba948a3a
2 files changed
+24 -2

No files matched your search

+22
View File
@@ -76,6 +76,17 @@ class FormContext implements FormContextInterface
return true; return true;
} }
public function formExecute($returnValue) : void
{
$this->formExecutionStatus = $returnValue;
$this->formExecuted = true;
if ($returnValue) {
$this->consumeCsrfToken();
}
}
public function executed() : bool public function executed() : bool
{ {
return $this->formExecutionStatus === false ? false : $this->formExecuted; return $this->formExecutionStatus === false ? false : $this->formExecuted;
@@ -109,6 +120,17 @@ class FormContext implements FormContextInterface
return $this->formExecutionStatus; return $this->formExecutionStatus;
} }
public function consumeCsrfToken() {
if (! $this->formSkipCsrf) {
$token = $this->get('picea-ui-form')[$this->formName] ?? false;
if ( $token ) {
# token is consumed
$_SESSION["picea-ui.form:{$this->formName}"] = array_diff($_SESSION["picea-ui.form:{$this->formName}"], [ $token ]);
}
}
}
public function getRequest() : ServerRequestInterface public function getRequest() : ServerRequestInterface
{ {
return $this->formContextRequest; return $this->formContextRequest;
+2 -2
View File
@@ -50,8 +50,8 @@ class FormHandler {
if ( $this->sent && $this->context->formSent() ) { if ( $this->sent && $this->context->formSent() ) {
if ( $this->validationStatus = $this->form->validate($this->context) ) { if ( $this->validationStatus = $this->form->validate($this->context) ) {
$this->context->formExecutionStatus = $this->executionStatus = $this->form->execute($this->context); $this->executionStatus = $this->form->execute($this->context);
$this->context->formExecuted = true; $this->context->formExecute($this->executionStatus);
} }
} }
} }